-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPORT] Embed reusable import module into GeoNature core #2833
Open
bouttier
wants to merge
496
commits into
develop
Choose a base branch
from
feat/import
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouttier
force-pushed
the
feat/import
branch
6 times, most recently
from
December 22, 2023 16:01
f3fc016
to
e459ff4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2833 +/- ##
===========================================
+ Coverage 81.62% 83.50% +1.88%
===========================================
Files 86 121 +35
Lines 6945 9538 +2593
===========================================
+ Hits 5669 7965 +2296
- Misses 1276 1573 +297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pierre-Narcisi
force-pushed
the
feat/import
branch
from
January 15, 2024 11:50
7338aea
to
d22bba0
Compare
bouttier
force-pushed
the
feat/import
branch
from
February 11, 2024 23:46
5a98659
to
c2e427b
Compare
VincentCauchois
changed the title
Embed reusable import module into GeoNature core
[IMPORT] Embed reusable import module into GeoNature core
Feb 14, 2024
Full name DEFAULT_GENERATE_MISSING_UUID=False
This allows to add an habitat without requiring to set the field value as database default value will be used.
Prohibit deletion of import with stations including habitats not originating from the same import.
20 tasks
- Remove AbstractMixin - Rename Destination's property from import_mixin to actions - Modules do not heritate import functions anymore
bouttier
force-pushed
the
feat/import
branch
from
September 13, 2024 07:03
c1f49dd
to
8eb917f
Compare
bouttier
force-pushed
the
feat/import
branch
from
September 19, 2024 14:00
ee1bc8e
to
dcdde5a
Compare
bouttier
force-pushed
the
feat/import
branch
from
September 19, 2024 15:02
dcdde5a
to
d64cff9
Compare
modues were missing from joined informations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reste à faire avant merge :
GeoNature/backend/geonature/core/gn_synthese/imports/actions.py
Line 240 in 5b73ada
technical_precision
: celui-ci devient obligatoire si le champsid_nomenclature_collection_technique
vaut 10 (« Autre, préciser ») [@Pierre-Narcisi] Exemple :GeoNature/backend/geonature/core/imports/checks/sql/nomenclature.py
Lines 136 to 151 in 5b73ada
display=False
) le fieldunique_dataset_id
(en attendant les colonnes virtuelles et la suppression de la sélection du jdd à l’étape 1)compute_bounding_box
> PR import: factorize bounding box #3184filter_by_scope
-> hook permettant de renvoyer un filtre SQL)resolve_import
(~has_instance_permission
)PR restantes :
Améliorations frontend :
Juste avant de merge :
feat/import
À vérifier :
metaclass_resolver
si encore présent dans le code source)Non bloquant :
Pour le futur :
cd_hab
: code typo (cd_typo ou cd_table) + lb_code [issue à ouvrir]