Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PPT-767 File Upload controller #357

Merged
merged 10 commits into from
Aug 21, 2023

Merge branch 'master' into PPT-767-file-upload-models

eeb77e5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: PPT-767 File Upload controller #357

Merge branch 'master' into PPT-767-file-upload-models
eeb77e5
Select commit
Loading
Failed to load commit list.
GitHub Actions / Ameba failed Aug 21, 2023 in 2s

Crystal Ameba Results

Total files checked: 95
Issues found: 2

Ameba Version: 1.4.3
Crystal Version: 1.7.0

Annotations

Check notice on line 61 in src/placeos-rest-api/controllers/asset_types.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Style/VerboseBlock

Use short block notation instead: `each(&.asset_count=(counts[type.id]? || 0_i64))`
Raw output
> results.each { |type| type.asset_count = counts[type.id]? || 0_i64 }
          ^

Check warning on line 177 in src/placeos-rest-api/controllers/uploads.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Metrics/CyclomaticComplexity

Cyclomatic complexity too high [12/10]
Raw output
> def update(
      ^