Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PPT-767 File Upload controller #357

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Aug 16, 2023

No description provided.

@github-actions
Copy link

Hey, your PR is titled Ppt 767 file upload models.
This is not a valid conventional commit.
Since we use well-formed PR titles for our changelogs, not fixing this can introduce problems :'(

@naqvis naqvis changed the title Ppt 767 file upload models feat: PPT-767 File Upload controller Aug 16, 2023
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a controller for managing the various buckets and a few other changes I've made comments for.
Looking great so far!

src/placeos-rest-api/controllers/uploads.cr Outdated Show resolved Hide resolved
src/placeos-rest-api/controllers/uploads.cr Outdated Show resolved Hide resolved
src/placeos-rest-api/controllers/uploads.cr Show resolved Hide resolved
Co-authored-by: Stephen von Takach <[email protected]>
@github-actions github-actions bot added the type: enhancement new feature or request label Aug 16, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 18, 2023
@naqvis naqvis requested a review from stakach August 18, 2023 03:13
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 18, 2023
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one minor change, also could you generate an updated open api docs

src/placeos-rest-api/controllers/uploads.cr Outdated Show resolved Hide resolved
@stakach
Copy link
Member

stakach commented Aug 21, 2023

@naqvis we actually need to be able to whitelist certain file types in the uploads.

Could we, as part of the storage model, add an optional array of file extensions types that we support?
Then on the upload controller check that the filename has a matching extension type

Probably worth doing the same with Mime Types so we can filter on either or both.

Co-authored-by: Stephen von Takach <[email protected]>
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 21, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 21, 2023
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Aug 21, 2023
@stakach stakach merged commit 62b871e into master Aug 21, 2023
7 of 9 checks passed
@stakach stakach deleted the PPT-767-file-upload-models branch August 21, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants