Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: deployment: add doc about ROOT_URL #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented May 21, 2024

No description provided.

@multun
Copy link
Contributor

multun commented May 21, 2024

I'm pretty sure more changes are needed to deploy OSRD on the internet using docker-compose. The docker compose setup is designed for development only: no authentication is supported, the front-end is served in development mode (rebuilt on the fly).

I'm not comfortable suggesting this setup unless someone puts real effort into making it safe

@Castavo Castavo requested review from Khoyo and ElysaSrc and removed request for multun and bloussou September 11, 2024 09:00
@Castavo
Copy link
Contributor Author

Castavo commented Sep 11, 2024

I added a commit about the limited purpose of the docker compose deployment method

Baptiste Prevot and others added 2 commits September 11, 2024 11:03
Copy link
Contributor

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel these changes are not required anymore since ROOT_URL is not used anymore : the gateway serves both on the same domain and the front uses a relative path. This setup prevents the need for setting the url and also prevents a bunch of CORS issues.

@Castavo
Copy link
Contributor Author

Castavo commented Sep 11, 2024

@ElysaSrc neat ! Then should I close the PR completely or keep it to add only the detail about the docker-compose deployment being a tad unsafe / not protection ready ?

@ElysaSrc
Copy link
Contributor

@ElysaSrc neat ! Then should I close the PR completely or keep it to add only the detail about the docker-compose deployment being a tad unsafe / not protection ready ?

As you wish, adding a word about the docker compose deployment being unfit for production is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants