-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guides: deployment: add doc about ROOT_URL #199
base: master
Are you sure you want to change the base?
Conversation
I'm pretty sure more changes are needed to deploy OSRD on the internet using docker-compose. The docker compose setup is designed for development only: no authentication is supported, the front-end is served in development mode (rebuilt on the fly). I'm not comfortable suggesting this setup unless someone puts real effort into making it safe |
c196655
to
4352e04
Compare
I added a commit about the limited purpose of the docker compose deployment method |
4352e04
to
6273305
Compare
Signed-off-by: Baptiste Prevot <[email protected]>
…tion Signed-off-by: Baptiste Prevot <[email protected]>
6273305
to
31f5986
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel these changes are not required anymore since ROOT_URL is not used anymore : the gateway serves both on the same domain and the front uses a relative path. This setup prevents the need for setting the url and also prevents a bunch of CORS issues.
@ElysaSrc neat ! Then should I close the PR completely or keep it to add only the detail about the docker-compose deployment being a tad unsafe / not protection ready ? |
As you wish, adding a word about the docker compose deployment being unfit for production is a good idea. |
No description provided.