-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viem 2 in toolbox in ethereumjs/main #4913
Conversation
🦋 Changeset detectedLatest commit: 3c9f582 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"@nomicfoundation/hardhat-network-helpers": "^1.0.0", | ||
"@nomicfoundation/hardhat-verify": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not related to hardhat-viem, but as we are already changing the file, we may go ahead and fix these.
"@nomicfoundation/hardhat-network-helpers": "^1.0.0", | |
"@nomicfoundation/hardhat-verify": "^2.0.0", | |
"@nomicfoundation/hardhat-network-helpers": "workspace:^1.0.0", | |
"@nomicfoundation/hardhat-verify": "workspace:^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't take them across as they weren't in ethereumjs/main
and I was wanting to keep these changes as focused as possible. When we backport our release changes into main
we definitely should add these in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change but LGTM
a11d1d3
to
3c9f582
Compare
This will be taken care of as part of the toolbox PR. |
Apply the follow on changes to the viem toolbox now that
hardhat-viem
support forviem@2
has been released.