Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viem 2 in toolbox in ethereumjs/main #4913

Closed
wants to merge 1 commit into from

Conversation

kanej
Copy link
Member

@kanej kanej commented Feb 21, 2024

Apply the follow on changes to the viem toolbox now that hardhat-viem support for viem@2 has been released.

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 3c9f582

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@nomicfoundation/hardhat-verify Patch
@nomicfoundation/hardhat-toolbox-viem Major
hardhat Patch
@nomicfoundation/edr Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 0:26am

Comment on lines 74 to 75
"@nomicfoundation/hardhat-network-helpers": "^1.0.0",
"@nomicfoundation/hardhat-verify": "^2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not related to hardhat-viem, but as we are already changing the file, we may go ahead and fix these.

Suggested change
"@nomicfoundation/hardhat-network-helpers": "^1.0.0",
"@nomicfoundation/hardhat-verify": "^2.0.0",
"@nomicfoundation/hardhat-network-helpers": "workspace:^1.0.0",
"@nomicfoundation/hardhat-verify": "workspace:^2.0.0",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take them across as they weren't in ethereumjs/main and I was wanting to keep these changes as focused as possible. When we backport our release changes into main we definitely should add these in.

Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change but LGTM

@kanej kanej marked this pull request as ready for review February 23, 2024 10:15
@kanej kanej force-pushed the viem-2-on-ehtereumjs-main-and-in-toolbox branch from a11d1d3 to 3c9f582 Compare March 8, 2024 12:25
@kanej kanej changed the base branch from viem-2-on-ethereumjs-main to main March 11, 2024 12:55
@kanej
Copy link
Member Author

kanej commented Mar 11, 2024

This will be taken care of as part of the toolbox PR.

@kanej kanej closed this Mar 11, 2024
@kanej kanej deleted the viem-2-on-ehtereumjs-main-and-in-toolbox branch May 9, 2024 19:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants