Bump viem related deps in hardhat-toolbox-viem #4904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1fe8bf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kanej
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Looks good.
I did a local test:
- Apply the changeset
- Publish (using pnpm) core, toolbox-viem and edr_napi to verdaccio
- Created a sample project, then bumped the viem toolbox
- Checked the installed versions
The npx hardhat test run failed. But I suspect that is EDR.
kanej
force-pushed
the
upgrade-viem-to-v2-toolbox
branch
from
5a19be9
to
1fe8bf1
Compare
|
Closing. We are going to have to approach this differently. Specifically recreating the viem release on the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.