Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.47.0 #403

Merged
merged 76 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
ca42a9f
added comments for changes
bpulluta Apr 12, 2024
2abc6cb
Merge branch 'industrial-process-heat' into add-process-heat-load
bpulluta May 7, 2024
a882bce
added built int process heat functionality
bpulluta May 8, 2024
45a0ab2
updated simulated load
bpulluta May 8, 2024
7e75341
adding results for process
bpulluta May 8, 2024
40cf19a
updated process heat load inside thermal
bpulluta May 9, 2024
48fed4b
updated process heat update
bpulluta May 14, 2024
c169e36
updated tests for process heat loads
bpulluta May 14, 2024
78a2d1b
merge develop
bpulluta May 14, 2024
20e7e25
merge from develop
bpulluta May 15, 2024
de0d2cb
Update .gitignore
hdunham May 16, 2024
c388903
add problem scenario to tests
hdunham May 17, 2024
1b8918f
add scenario json
hdunham May 17, 2024
b0f72ac
check problem scenario erros
hdunham May 17, 2024
d02bbc9
convert max_electric_load_kw to float
hdunham May 17, 2024
3e0cd21
check no error
hdunham May 17, 2024
28145a6
remove debugging changes
hdunham May 17, 2024
06f25b3
Revert "Update .gitignore"
hdunham May 17, 2024
235972b
Update CHANGELOG.md
hdunham May 17, 2024
85eff19
dont average rates in each energy tier when unit in urdb response isn…
hdunham May 17, 2024
e39cfed
rm unused var
hdunham May 19, 2024
dd5d0ed
Update CHANGELOG.md
hdunham May 19, 2024
a8c8955
Add third party factor multiplier to PV O&M results
lixiangk1 May 20, 2024
dad5387
Update CHANGELOG.md
lixiangk1 May 20, 2024
9defb8d
error when exotic energy tier units
hdunham May 21, 2024
07be552
Update CHANGELOG.md
hdunham May 21, 2024
4310414
supposed to be inside for loop
hdunham May 22, 2024
80c0d62
Merge pull request #397 from NREL/chp-default-bug
hdunham May 22, 2024
2848de8
Merge branch 'develop' into urdb-unit-bug
hdunham May 22, 2024
5838381
Add test for exotic units detected
zolanaj May 22, 2024
e8ff44d
Merge branch 'develop' into pv_om_third_party_factor
adfarth May 22, 2024
d9780dd
Update CHANGELOG.md
adfarth May 22, 2024
e2c4670
Merge pull request #399 from NREL/pv_om_third_party_factor
adfarth May 22, 2024
0a964a2
Merge branch 'develop' into urdb-unit-bug
hdunham May 23, 2024
ac4d9f3
fix changelog merge
hdunham May 23, 2024
1fec0bb
Merge pull request #398 from NREL/urdb-unit-bug
hdunham May 23, 2024
53cbc47
refactor heating flow constraints, move from storage to thermal_tech_…
zolanaj May 23, 2024
46264a3
throw error if steam turbine is present but no techs can supply it
zolanaj May 23, 2024
e2e65ab
new testset "CHP to Waste Heat"
zolanaj May 23, 2024
707cd70
fix tests in new set
zolanaj May 23, 2024
266c278
Update CHANGELOG.md
zolanaj May 23, 2024
d5609d9
update version #s
hdunham May 23, 2024
8e837dd
update constraint sets when turbine is present
zolanaj May 23, 2024
77482fe
turn on presolve for CHP test
zolanaj May 23, 2024
6e2ad5b
rm zero-size techs from test case (avoid PVWatts call)
zolanaj May 23, 2024
2f2c935
tax rate update
adfarth May 24, 2024
668384f
initiate PV in CHP cost curve test
zolanaj May 24, 2024
d79aecd
make CHP size test more flexible
zolanaj May 24, 2024
b79d14d
updated process heat tests
bpulluta May 24, 2024
5cf7209
Merge branch 'develop' into add-process-heat-load
bpulluta May 24, 2024
c6ff82e
Updated runtest.jl with correct DotEnv variable
bpulluta May 24, 2024
e56be43
fixed scenario.jl for processheat to include lat-long
bpulluta May 24, 2024
392fbb2
updated failing test from thermal_load
bpulluta May 24, 2024
6d10800
updated heating loads test
bpulluta May 25, 2024
d6943f9
Fix type errors for blended_industrial_reference_ names and percents
Bill-Becker May 27, 2024
b07d4a9
Merge branch 'add-process-heat-load' of https://github.com/NREL/REopt…
Bill-Becker May 27, 2024
614a512
Make separate load_type option for space_heating, dhw, and process_heat
Bill-Becker May 28, 2024
f228a91
Remove process_heat from load_type="heating"
Bill-Becker May 28, 2024
5510760
Fix wrong file loading
Bill-Becker May 28, 2024
4366454
Add expected ProcessHeatLoad to ElectricHeater test
Bill-Becker May 28, 2024
85dcd22
Update simulated load test with updated process heat handling
Bill-Becker May 28, 2024
9133b31
Merge pull request #407 from NREL/tax-rate
adfarth May 28, 2024
f0ec702
added process to emissions test
bpulluta May 28, 2024
9ededdf
Update CHANGELOG.md
adfarth May 28, 2024
3ede901
Merge branch 'develop' into add-process-heat-load
bpulluta May 29, 2024
c1eff6f
revert emission test for heating
bpulluta May 29, 2024
7c522f4
updated changelog for process heat
bpulluta May 29, 2024
d1e85ec
updated changelog version for merging into develop
bpulluta May 29, 2024
63e8eda
Merge branch 'develop' into enforce-waste-heat-tracking
zolanaj May 29, 2024
418275f
Merge pull request #396 from NREL/add-process-heat-load
bpulluta May 30, 2024
50b59ab
small fix to help text
adfarth May 30, 2024
00d94cd
Merge branch 'master' into develop
Bill-Becker May 30, 2024
9f5bf3c
Update CHANGELOG.md
Bill-Becker May 30, 2024
556e30c
Update Project.toml to v0.47.0
Bill-Becker May 30, 2024
1784d09
Merge branch 'develop' into enforce-waste-heat-tracking
zolanaj May 30, 2024
bd391d8
Merge pull request #404 from NREL/enforce-waste-heat-tracking
zolanaj May 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,28 @@ Classify the change according to the following categories:
### Deprecated
### Removed

## v0.47.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting there is a version conflict between the changelog and the manifest.toml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also one other note: ProcessHeatLoad was already part of the v46.0 update, so perhaps update that to BuiltInProcessHeatLoad?

Copy link
Collaborator

@bpulluta bpulluta May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zolanaj @Bill-Becker , let me know if there is anything i can do to help fix these inconsistencies. Since I can't change it directly on dev, I can start a branch if necessary to update the Changelog

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed all of the redundant ones from v0.46.0 and replaced with a general description of what was added for ProcessHeatLoad, to supplement the other bullet points in the Updated section.

### Added
- In `src/core/heating_cooling_loads.jl`, added new struct **ProcessHeatLoad**.
- In `src/core/scenario.jl`, added new field **process_heat_load**.
- Added new results fields **process_heat_thermal_load_series_mmbtu_per_hour**, **process_heat_boiler_fuel_load_series_mmbtu_per_hour**, **annual_calculated_process_heat_thermal_load_mmbtu**, and **annual_calculated_process_heat_boiler_fuel_load_mmbtu** to HeatingLoad results, with sum heating loads now including process heat.

### Changed
- Updated `test/scenarios/thermal_load.json` to include **ProcessHeatLoad** in both hourly and monthly fuel load tests.
- Refactored test sets in `test/runtests.jl` to include **ProcessHeatLoad** and ensure it is treated similarly to **DomesticHotWaterLoad** and **SpaceHeatingLoad**.
- Modified **dvHeatingProduction** to account for **ProcessHeatLoad** with relevant addressable load fractions.
- Updated test values and expectations to include contributions from **ProcessHeatLoad**.
- Updated `src/core/doe_commercial_reference_building_loads.jl` to include **ProcessHeatLoad** for built-in load handling.
- Refactored various functions to ensure **ProcessHeatLoad** is processed correctly in line with other heating loads.

## v0.46.2
### Changed
- When the URDB response `energyratestructure` has a "unit" value that is not "kWh", throw an error instead of averaging rates in each energy tier.
- Changed default Financial **owner_tax_rate_fraction** and **offtaker_tax_rate_fraction** from 0.257 to 0.26 to align with API and user manual defaults.
### Fixed
- Updated the PV result **lifecycle_om_cost_after_tax** to account for the third-party factor for third-party ownership analyses.
- Convert `max_electric_load_kw` to _Float64_ before passing to function `get_chp_defaults_prime_mover_size_class`

## v0.46.1
### Changed
- Updated the GHP testset .json `./test/scenarios/ghp_inputs.json` to include a nominal HotThermalStorage and ColdThermalStorage system.
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "REopt"
uuid = "d36ad4e8-d74a-4f7a-ace1-eaea049febf6"
authors = ["Nick Laws", "Hallie Dunham <[email protected]>", "Bill Becker <[email protected]>", "Bhavesh Rathod <[email protected]>", "Alex Zolan <[email protected]>", "Amanda Farthing <[email protected]>"]
version = "0.46.1"
version = "0.46.2"

[deps]
ArchGDAL = "c9ce4bd3-c3d5-55b8-8973-c0e20141b8c3"
Expand Down
Loading
Loading