Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.47.0 #403

Merged
merged 76 commits into from
May 31, 2024
Merged

v0.47.0 #403

merged 76 commits into from
May 31, 2024

Conversation

Bill-Becker and others added 7 commits May 27, 2024 21:09
This load_type was intended to provide default ratios of space heating and DHW heating for DOE commercial reference buildings

We won't have a similar reference building to include process heat as well.
@adfarth adfarth changed the title bug fixes (pv 3rd party factor in O&M, chp var type conversion, Urdu exotic units) v0.46.2 bug fixes (pv 3rd party factor in O&M, chp var type conversion, Urdu exotic units) May 28, 2024
@adfarth adfarth changed the title v0.46.2 bug fixes (pv 3rd party factor in O&M, chp var type conversion, Urdu exotic units) v0.46.2 bug fixes (pv 3rd party factor in O&M, chp var type conversion, Urdu exotic units, tax rate) May 28, 2024
@Bill-Becker
Copy link
Collaborator

@hdunham should we switch the description of this to just point to the different PR's that were merged into develop? (and update to just putting everything under the one new version v0.47.0).

@Bill-Becker Bill-Becker self-requested a review May 30, 2024 18:21
@Bill-Becker
Copy link
Collaborator

@zolanaj I can take care of the review portion related to @bpulluta's ProcessHeat inputs processing addition.

Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was intended to be a swift approval and I didn't send it out. Approving pending @Bill-Becker's notes with a couple comments on the changelog.

@@ -23,6 +23,28 @@ Classify the change according to the following categories:
### Deprecated
### Removed

## v0.47.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting there is a version conflict between the changelog and the manifest.toml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also one other note: ProcessHeatLoad was already part of the v46.0 update, so perhaps update that to BuiltInProcessHeatLoad?

Copy link
Collaborator

@bpulluta bpulluta May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zolanaj @Bill-Becker , let me know if there is anything i can do to help fix these inconsistencies. Since I can't change it directly on dev, I can start a branch if necessary to update the Changelog

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed all of the redundant ones from v0.46.0 and replaced with a general description of what was added for ProcessHeatLoad, to supplement the other bullet points in the Updated section.

@Bill-Becker Bill-Becker changed the title v0.46.2 bug fixes (pv 3rd party factor in O&M, chp var type conversion, Urdu exotic units, tax rate) v0.47.0 May 30, 2024
@Bill-Becker Bill-Becker merged commit c148622 into master May 31, 2024
3 checks passed
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants