MOL-29362: fix ESlint 9 BREAKING CHANGES #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer needed. we use github actions for Open Source packages now Issues: MOL-29362
node.js < v18.18, v19 are no longer supported. https://eslint.org/docs/latest/use/migrate-to-9.0.0#-nodejs--v1818-v19-are-no-longer-supported Issues: MOL-29362
no longer needed. we use github actions for Open Source packages now Issues: MOL-29362
greenkeeper is deprecated in favor of Snyk Issues: MOL-29362
Issues: MOL-29362
after agreed this with Carlos Serrano, remove support for flow. We don't use it and it brings some unneeded complexity to the package. BREAKING CHANGE: remove support for Flow Issues: MOL-29362
thus, we are allowed to add comments to the rules Issues: MOL-29362
eslint 9 is still too new and its ecosystem is simply not ready yet, so we (Carlos Serrano and me) decided to downgrade it to eslint 8. Also remove babel-eslint since it is discontinued in favour of the default eslint parser "espree" BREAKING CHANGE: downgrade eslint from 9 to 8 Issues: MOL-29362
Txabox
force-pushed
the
fix/MOL-29362-fix-ESlint-9-migration-breaking-changes
branch
from
022d574
to
1d4383b
Compare
…emoved as seen here: gajus/eslint-plugin-jsdoc#1031 BREAKING CHANGE: remove "jsdoc/newline-after-description" rule Issues: MOL-29362
after discussed about it in the mol-fe-devs channel in Slack and having the approval of Carlos Serrano BREAKING CHANGE: upgrade ecmaScript from 2017 to 2021 Issues: MOL-29362
this change addresses use cases in mol-fe-sync-bundler where local styles need to be loaded before absolute imports. BREAKING CHANGE: The 'absolute-first' condition from the import/first rule has been removed. Issues: MOL-29362
agreed with Carlos Serrano. we are not using mocha anymore in any relevant package BREAKING CHANGE: remove support for eslint-plugin-mocha Issues: MOL-29362
Issues: MOL-29362
ilya-zhuravel
approved these changes
Apr 30, 2024
carpasse
approved these changes
May 2, 2024
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: MOL-29362