MOL-29362: fix ESlint 9 BREAKING CHANGES

.gitignore

@@ -4,5 +4,4 @@ node_modules
 !.husky
 !.gitignore
 !.npmignore
-!.travis.yml
 package-lock.json

.husky/pre-commit

@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npm run lint && npm run test && npm run format
+npm run lint && npm run test

README.md

@@ -1,25 +1,36 @@
 # `eslint-config-mailonline`
 
-[![Greenkeeper badge](https://badges.greenkeeper.io/MailOnline/eslint-config-mailonline.svg)](https://greenkeeper.io/)
-
 [![NPM version](http://img.shields.io/npm/v/eslint-config-mailonline.svg?style=flat-square)](https://www.npmjs.org/package/eslint-config-mailonline)
-[![Travis build status](http://img.shields.io/travis/MailOnline/eslint-config-mailonline/master.svg?style=flat-square)](https://travis-ci.org/MailOnline/eslint-config-mailonline)
 
-MailOnline ESLint configuration.
+`eslint-config-mailonline` is a shared ESLint configuration used by MailOnline. This configuration includes rules for ES6, React, Jest, Lodash, and Webpack.
 
-## Usage
+## Prerequisites
+
+- Node.js v18.18 or higher
+
+## Installation
 
 Add `eslint-config-mailonline` as a development dependency:
 
+For *npm* users:
 ```bash
 npm install eslint-config-mailonline --save-dev
 ```
 
-Create ESLint configuration file (`.eslintrc`) that extends `eslint-config-mailonline`:
+For *Yarn* users:
+```bash
+yarn add eslint-config-mailonline --dev
+```
 
-```json
+Please note that there is no requirement to install stylelint independently in the parent package. This is because it is included as a dependency within this library and will be hoisted to the parent package.
+
+## Usage
+
+Create ESLint configuration file (`eslint.json`) that extends `eslint-config-mailonline`:
+
+```js
 {
-  "extends": "mailonline"
+  "extends": "mailonline",
 }
 ```
 
@@ -28,62 +39,46 @@ Create ESLint configuration file (`.eslintrc`) that extends `eslint-config-mailo
 The package also has separate entry points for some environments. Simply extend from the entry point as described below,
 either in a folder-specific eslint config, or additionally to the root config, e.g.:
 
-```json
-{
+```js
+module.exports = {
   "extends": [
     "mailonline",
     "mailonline/jest",
     "mailonline/react"
   ]
-}
+};
 ```
 
 ### jest
 
-```json
-{
+```js
+module.exports = {
   "extends": "mailonline/jest"
-}
-```
-
-### mocha
-
-```json
-{
-  "extends": "mailonline/mocha"
-}
+};
 ```
 
 ### react
 
-```json
-{
+```js
+module.exports = {
   "extends": "mailonline/react"
-}
-```
-
-### flowtype
-
-```json
-{
-  "extends": "mailonline/flowtype"
-}
+};
 ```
 
 ### lodash
 
-```json
-{
+```js
+module.exports = {
   "extends": "mailonline/lodash"
-}
+};
 ```
 
 ### webpack
 
-```json
-{
+```js
+module.exports = {
   "extends": "mailonline/webpack"
-}
+};
 ```
 
 ## Breaking changes

configurations/base.json → configurations/base.js

@@ -1,18 +1,18 @@
-{
+module.exports = {
   "env": {
     "browser": true,
     "es6": true,
     "node": true
   },
-  "parser": "babel-eslint",
+  "parser": "espree", // default one: https://eslint.org/docs/v8.x/use/configure/parser
   "parserOptions": {
     "ecmaFeatures": {
       "experimentalObjectRestSpread": true,
       "globalReturn": false,
       "impliedStrict": true,
       "jsx": true
     },
-    "ecmaVersion": 2017,
+    "ecmaVersion": 2021,
     "sourceType": "module"
   },
   "plugins": [
@@ -166,10 +166,7 @@
         "json": "always"
       }
     ],
-    "import/first": [
-      2,
-      "absolute-first"
-    ],
+    "import/first": 2,
     "import/max-dependencies": 0,
     "import/named": 2,
     "import/namespace": 2,
@@ -234,10 +231,6 @@
     "jsdoc/check-param-names": 1,
     "jsdoc/check-tag-names": 1,
     "jsdoc/check-types": 1,
-    "jsdoc/newline-after-description": [
-      1,
-      "always"
-    ],
     "jsdoc/require-description-complete-sentence": 1,
     "jsdoc/require-hyphen-before-description": 0,
     "jsdoc/require-param": 0,
@@ -658,4 +651,4 @@
       ".js"
     ]
   }
-}
+};

configurations/jest.json → configurations/jest.js

@@ -1,4 +1,4 @@
-{
+module.exports = {
   "env": {
     "jest": true
   },
@@ -11,4 +11,4 @@
     "jest/no-identical-title": "error",
     "jest/valid-expect": "error"
   }
-}
+};

configurations/lodash.json → configurations/lodash.js

@@ -1,4 +1,4 @@
-{
+module.exports = {
   "plugins": [
     "lodash"
   ],
@@ -65,4 +65,4 @@
     "lodash/prop-shorthand": 1,
     "lodash/unwrap": 1
   }
-}
+};

configurations/react.json → configurations/react.js

@@ -1,4 +1,4 @@
-{
+module.exports = {
   "plugins": [
     "react"
   ],
@@ -104,4 +104,4 @@
     "react/style-prop-object": 2,
     "react/void-dom-elements-no-children": 2
   }
-}
+};

configurations/webpack.json → configurations/webpack.js

@@ -1,5 +1,5 @@
-{
+module.exports = {
 "settings": {
   "import/resolver": "webpack"
   }
-}
+};

index.js

@@ -1 +1 @@
-module.exports = require('./configurations/base.json');
+module.exports = require('./configurations/base');

jest.js

@@ -1 +1 @@
-module.exports = require('./configurations/jest.json');
+module.exports = require('./configurations/jest');

lodash.js

@@ -1 +1 @@
-module.exports = require('./configurations/lodash.json');
+module.exports = require('./configurations/lodash');

package.json

@@ -4,31 +4,24 @@
     "eslint-import-resolver-webpack": "^0.13.8"
   },
   "dependencies": {
-    "babel-eslint": "^10.1.0",
+    "eslint": "^8.57.0",
     "eslint-plugin-babel": "^5.3.1",
     "eslint-plugin-filenames": "^1.3.2",
-    "eslint-plugin-flowtype": "^8.0.3",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jest": "^28.2.0",
     "eslint-plugin-jsdoc": "^48.2.3",
     "eslint-plugin-lodash": "^7.4.0",
-    "eslint-plugin-mocha": "^10.4.2",
     "eslint-plugin-no-use-extend-native": "^0.5.0",
     "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-react": "^7.34.1",
     "eslint-plugin-unicorn": "^52.0.0"
   },
   "devDependencies": {
-    "eslint": "^9.0.0",
     "husky": "^7.0.2",
-    "jsonlint": "^1.6.3",
     "semantic-release": "^22.0.12"
   },
   "engines": {
-    "node": ">=18"
-  },
-  "peerDependencies": {
-    "eslint": "^7.32.0"
+    "node": ">=18.18"
   },
   "keywords": [
     "eslint",
@@ -47,7 +40,6 @@
     "url": "https://github.com/mailonline/eslint-config-mailonline"
   },
   "scripts": {
-    "format": "jsonlint --sort-keys --in-place --indent '  ' ./configurations/*.json",
     "lint": "echo 'This project has no linting' && exit 0",
     "prepare": "husky install",
     "semantic-release": "semantic-release",

react.js

@@ -1 +1 @@
-module.exports = require('./configurations/react.json');
+module.exports = require('./configurations/react');

webpack.js

@@ -1 +1 @@
-module.exports = require('./configurations/webpack.json');
+module.exports = require('./configurations/webpack');