Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK #2265

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK #2265

merged 5 commits into from
Sep 24, 2020

Conversation

Werni2A
Copy link
Contributor

@Werni2A Werni2A commented May 2, 2020

Adds the 20W AC/DC converter series RAC20.

https://recom-power.com/pdf/Powerline_AC-DC/RAC20-K.pdf
FP geometry

image
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@CLAassistant
Copy link

CLAassistant commented May 2, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels May 4, 2020
@aris-kimi
Copy link
Collaborator

Hi @Werni2A , thank you for your contribution.
From the image shown i can sugget to clear that triangle shaped pin1 fab indicator. 1mm bevel at the top left corner is the appropriate way.

@Werni2A
Copy link
Contributor Author

Werni2A commented Aug 30, 2020

Hi @aris-kimi , thanks for taking a look at the footprint. I think this was my first contribution to the library. From my current point of view there are a few aspects that I want to change.

The most important one is that this kind of packages are quite common therefore I will try to write a generator script for it. Until then I mark this PR as WIP.

@Werni2A Werni2A changed the title Add AC/DC converters Recom RAC20-xxSK WIP: Add AC/DC converters Recom RAC20-xxSK Aug 30, 2020
@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 5, 2020

@aris-kimi I updated the footprint. It would be great if you could take a look at it :)

This time created with footprint-generator

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 5, 2020

Semms like you were faster with linking the according generator ;)

@Werni2A Werni2A changed the title WIP: Add AC/DC converters Recom RAC20-xxSK Add AC/DC converters Recom RAC20-xxSK Sep 5, 2020
@Werni2A Werni2A changed the title Add AC/DC converters Recom RAC20-xxSK Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK Sep 5, 2020
(fp_text user "" (at -3 0) (layer F.SilkS)
(effects (font (size 1 1) (thickness 0.15)))
)
(model ${KISYS3DMOD}/Converter_DCDC.3dshapes/Converter_ACDC_Recom_RAC20-xxDK_THT.wrl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evanshultz and @myfreescalewebpage , this 3D path is wrong, because the script used was about DC/DC converters, can AC/DC added at the scripts?
If not i will advice to manually edit..Same for the second part.
I haven't reviewed them yet..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it would be great to make the script more generic e.g. passing the library as a parameter. Also passing the drill diameter without any pad information would be nice as this dimensions can be calculated via the IPC standard and most datasheets don't specify the pads.

@Franck78
Copy link

Franck78 commented Sep 6, 2020

While I'm at working on those converters, I can add the 3dfootprint for this RAC20 series.
Don't add them, now it's 5 minutes to do the addition for me

KiCad/kicad-packages3D#600

Just, I don't really know if I put the 3dimages in my current KiCad/kicad-packages3D#721 PR
which allready have one converter or try another PR with all images.
?

@Franck78
Copy link

Franck78 commented Sep 6, 2020

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 6, 2020

@Franck78 great that you add 3D models, I personally have no experience in creating those models. 👍

I think it's best to create a new PR and link it to this one. When everything is in only one PR it slows the whole process down as every part has to be checked before it can be merged. But I'm no librarian so that's just the impression I got.

@Franck78
Copy link

Franck78 commented Sep 6, 2020

have you tried the 3D on the footprint just to confirm it is good ?

Yes, with 5 or more repo to follow, it is rapidly becoming messy.
I have about 12 new models, they must accept that as one thing or two, not twelve .

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 6, 2020

I haven't checked the dimensions but it looks good from a "optical inspection" :)
image

@Franck78
Copy link

Franck78 commented Sep 7, 2020

on the other side, the white line must follow the body, no space, no hide.

@myfreescalewebpage myfreescalewebpage self-assigned this Sep 24, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 24, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 24, 2020

@Werni2A starting the review here.

For both footprints:

  • The description is very long, is speaking about a script we don't know and the datasheet is indicated twice. To be cleanup.
  • The diameter of the pad is a little bit small based on the other converters. I suggest diameter=2.4mm and hole=1.3mm.

Joel

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

Hi @myfreescalewebpage thanks for taking a look at this PR and sorry for the work.

The Converter_DCDC generator is not very well suited for this footprints. As soon as pointhi/kicad-footprint-generator#624 is merged I wanted to rework/replace Converter_DCDC with a more generic DIP package generator.

Until someone is terribly in need for this footprint I would like to keep it on hold until I wrote the generator.

@Werni2A Werni2A changed the title Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK WIP: Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK Sep 24, 2020
@myfreescalewebpage
Copy link
Collaborator

As you wish, but there are only few comments on the footprint and KiCad/kicad-symbols#2692 is waiting for this to be merged, so I think it can be very nice to finish manually and update later with scripted version.
I let you decide what you want to do.
Joel

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

@myfreescalewebpage your comment is a good point. I updated the footprints manually. There were also some empty "user text" in the footprint that I removed.

@Werni2A Werni2A changed the title WIP: Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK Sep 24, 2020
@myfreescalewebpage
Copy link
Collaborator

Thanks, at the moment the footprints can be merged. Up to you for a very nice converter script (you're welcome to do that !!)

@myfreescalewebpage myfreescalewebpage merged commit 879c54e into KiCad:master Sep 24, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 6.0.0 milestone Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants