Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up DD bounds #339

Merged
merged 3 commits into from
Oct 5, 2023
Merged

up DD bounds #339

merged 3 commits into from
Oct 5, 2023

Conversation

lazarusA
Copy link
Collaborator

@lazarusA lazarusA commented Oct 5, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Pull Request Test Coverage Report for Build 6423403870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.571%

Totals Coverage Status
Change from base Build 6369683864: 0.0%
Covered Lines: 1235
Relevant Lines: 1750

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

see 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@felixcremer
Copy link
Member

Your changes make the benchmarking action fail somehow. The failure is really confusing. I am going to merge it now and we should see, whether this also fails, when it is merged on master.
There seems to be some version mismatch between the DimensionalData version that is in the normal Project.toml and what is expected in the Benchmarking environment but there Dimensionaldata is not specified.

@felixcremer felixcremer merged commit 5b92d6d into master Oct 5, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants