Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(client/electron/linux): remove the "Beta" from the title bar #1940

Merged
merged 3 commits into from
Apr 1, 2024
Merged

chore(client/electron/linux): remove the "Beta" from the title bar #1940

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53b809d
chore(client/electron/build): remove the "Beta" from the title bar
sbruens Mar 29, 2024
e1ea50f
Merge branch 'master' into sbruens/linux-title
daniellacosse Apr 1, 2024
52b5a1d
Merge branch 'master' into sbruens/linux-title
sbruens Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/www/index_electron.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=no" />
</head>
<body unresolved>
<script>
// exposed in preload.ts
if (window.electron.os.platform === 'linux') {
document.title = 'Outline Beta';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had this because we're not supported in every linux distro? 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it dated all the way back to the initial beta release of the Linux client in 2018.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but the fact we don't support every linux distro today is also true. I think it's fine though, it's just that that's what I was told when I mentioned this a year or so ago

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had it as Beta because it was just a system proxy when we first launched.

}
</script>
<app-root></app-root>
</body>
</html>
Loading