Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client/electron/linux): remove the "Beta" from the title bar #1940

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Apr 1, 2024

No description provided.

@sbruens sbruens requested a review from a team as a code owner April 1, 2024 09:27
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40%. Comparing base (dea1ca1) to head (52b5a1d).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1940   +/-   ##
======================================
  Coverage      40%     40%           
======================================
  Files          39      39           
  Lines        1816    1816           
  Branches      340     340           
======================================
  Hits          739     739           
  Misses       1077    1077           
Flag Coverage Δ
unittests 40% <ø> (ø)
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbruens sbruens changed the title chore(client/electron/build): remove the "Beta" from the title bar chore(client/electron/linux): remove the "Beta" from the title bar Apr 1, 2024
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

<script>
// exposed in preload.ts
if (window.electron.os.platform === 'linux') {
document.title = 'Outline Beta';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had this because we're not supported in every linux distro? 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it dated all the way back to the initial beta release of the Linux client in 2018.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but the fact we don't support every linux distro today is also true. I think it's fine though, it's just that that's what I was told when I mentioned this a year or so ago

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had it as Beta because it was just a system proxy when we first launched.

@sbruens sbruens merged commit 29ee26f into master Apr 1, 2024
21 checks passed
@sbruens sbruens deleted the sbruens/linux-title branch April 1, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants