-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(client/electron/linux): remove the "Beta" from the title bar #1940
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1940 +/- ##
======================================
Coverage 40% 40%
======================================
Files 39 39
Lines 1816 1816
Branches 340 340
======================================
Hits 739 739
Misses 1077 1077
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
<script> | ||
// exposed in preload.ts | ||
if (window.electron.os.platform === 'linux') { | ||
document.title = 'Outline Beta'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had this because we're not supported in every linux distro? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it dated all the way back to the initial beta release of the Linux client in 2018.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but the fact we don't support every linux distro today is also true. I think it's fine though, it's just that that's what I was told when I mentioned this a year or so ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had it as Beta because it was just a system proxy when we first launched.
No description provided.