Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(www): fix END_OF_LINK placeholders #1924

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Mar 8, 2024

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40%. Comparing base (2501ca3) to head (ac82c03).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1924    +/-   ##
=======================================
+ Coverage      32%     40%    +7%     
=======================================
  Files          45      39     -6     
  Lines        2610    1806   -804     
  Branches      337     337            
=======================================
- Hits          859     738   -121     
+ Misses       1751    1068   -683     
Flag Coverage Δ
apple ?
ios ?
macos ?
unittests 40% <ø> (+7%) ⬆️
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbruens sbruens requested a review from jyyi1 March 8, 2024 15:35
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbruens sbruens merged commit 14e0a07 into master Mar 11, 2024
21 of 22 checks passed
@sbruens sbruens deleted the sbruens/end-of-link branch March 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants