chore(www): add meaning attribute to messages with updated placeholders
#1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of placeholders
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1934 +/- ##
======================================
Coverage 32% 32%
======================================
Files 45 45
Lines 2620 2620
Branches 340 340
======================================
Hits 860 860
Misses 1760 1760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jyyi1
reviewed
Mar 19, 2024
jyyi1
approved these changes
Mar 20, 2024
daniellacosse
pushed a commit
that referenced
this pull request
Apr 1, 2024
…ders (#1934) * chore(www): add `meaning` attribute to messages with mismatched number of placeholders * Use a more specific meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1924 updated the placeholders of an existing message, without changing the message ID. This is a problem in the Translation Console as it can mess up existing translations that are based on a single placeholder. Here I'm changing the message ID by adding the
meaningattribute, as suggested.