Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(www): localization export for Outline Apps #1921

Closed
wants to merge 1 commit into from

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Mar 6, 2024

chore(www): localization export for Outline Apps

@sbruens sbruens requested a review from a team as a code owner March 6, 2024 17:41
Copy link

google-cla bot commented Mar 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40%. Comparing base (699363c) to head (5c3812d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1921    +/-   ##
=======================================
+ Coverage      32%     40%    +7%     
=======================================
  Files          45      39     -6     
  Lines        2610    1806   -804     
  Branches      337     337            
=======================================
- Hits          859     738   -121     
+ Misses       1751    1068   -683     
Flag Coverage Δ
apple ?
ios ?
maccatalyst ?
macos ?
unittests 40% <ø> (+7%) ⬆️
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so cool that these are decoupled and automated now~

@sbruens
Copy link
Contributor Author

sbruens commented Mar 7, 2024

so cool that these are decoupled and automated now~

I know. I am going to see if Copybara can move this PR forward now in the post-submit flow.

@sbruens sbruens force-pushed the copybara/613246717 branch 2 times, most recently from cad7e50 to ee4d3ec Compare March 12, 2024 16:25
@sbruens
Copy link
Contributor Author

sbruens commented Mar 12, 2024

The original default author can't sign the CLA, so going to try this again with updated Copybara configs.

@sbruens sbruens deleted the copybara/613246717 branch March 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants