-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cordova/android): fix import_messages
script for Android and move it to Node
#1674
Conversation
import_messages
script for Android and move it to Node.import_messages
script for Android and move it to Node.
Btw I think we can delete the |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1674 +/- ##
=======================================
+ Coverage 36% 45% +9%
=======================================
Files 45 39 -6
Lines 2756 1943 -813
Branches 312 312
=======================================
- Hits 1006 885 -121
+ Misses 1750 1058 -692
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, seems fine. Delete that extra python file if we no longer need it. One fewer language for third party contributors to need to know about!
import_messages
script for Android and move it to Node.import_messages
script for Android and move it to Node
Removed |
For posterity, turns out the reason this broke in #1674 was because of some XML characters (i.e. |
No description provided.