fix(devtools): fix the import_messages script
#1673
Conversation
sbruens
changed the title
import_messages scriptimport_messages script
sbruens
changed the title
import_messages scriptimport_messages script
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1673 +/- ##
======================================
Coverage 36% 36%
======================================
Files 45 45
Lines 2756 2756
Branches 312 312
======================================
Hits 1006 1006
Misses 1750 1750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Should we generate these at build time instead? That would ensure they are always in sync with the messages.
There was a problem hiding this comment.
Yeah, I was thinking about this as well. Will take a look at that in a follow-up - was going to make some adjustments incrementally.
Do we still want a copy of these files checked-in as well or completely remove them from the repo?
There was a problem hiding this comment.
In that case we should remove the generated files from the repo.
I'll let @daniellacosse review this PR.
There was a problem hiding this comment.
I pointed Sander to this old PR I never got around to finishing: #1508
The plan is to get this into node first, then I'll add it to the build and delete the files in a subsequent PR.
There was a problem hiding this comment.
Alright I'll abandon this in favor of #1674.
|
Closing in favor of #1674 |
Fixing the
import_messagesscript ready to be expanded to allow us to write localization files for the Catalyst app on iOS.