refactor(cordova/apple/ios): remove reachability test #1663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test adds too much complexity, without much value.
Most importantly, it requires the per-platform code to inspect the config, which we want to avoid.
This is a step closer to config-agnostic platform code.
I'm removing the reachability code from iOS. We can do the same cleanup on Android and outline-go-tun2socks, but I'll leave that for later, since it doesn't block the config work.
/cc @bi-kh @daniellacosse @sbruens