Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client/cordova/android): remove dead reachability test code #2054

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Jul 18, 2024

The logic has already been removed in #1663 , this PR cleans up the dead code for Android.

@jyyi1 jyyi1 requested a review from a team as a code owner July 18, 2024 21:57
@jyyi1 jyyi1 requested review from fortuna and sbruens July 18, 2024 21:57
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for cleaning this up.

@jyyi1 jyyi1 merged commit 2f4009f into master Jul 19, 2024
21 checks passed
@jyyi1 jyyi1 deleted the junyi/remove-reachable-test branch July 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants