Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(www): improve error messaging and update zero-state footer to point to the Manager #1662

Merged
merged 7 commits into from
Jul 27, 2023
Merged

chore(www): improve error messaging and update zero-state footer to point to the Manager #1662

merged 7 commits into from
Jul 27, 2023

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +30% 🎉

Comparison is base (e368323) 15% compared to head (3272dc3) 45%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #1662     +/-   ##
========================================
+ Coverage      15%     45%    +30%     
========================================
  Files           6      39     +33     
  Lines         806    1943   +1137     
  Branches        0     312    +312     
========================================
+ Hits          121     885    +764     
- Misses        685    1058    +373
Flag Coverage Δ
apple ?
ios ?
macos ?
unittests 45% <ø> (+30%) ⬆️
www 45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/www/views/servers_view/index.ts 69% <ø> (ø)

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fortuna fortuna requested a review from maddyhof July 11, 2023 19:02
maddyhof
maddyhof approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@maddyhof maddyhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniellacosse daniellacosse marked this pull request as ready for review July 25, 2023 16:03
@daniellacosse daniellacosse requested a review from a team as a code owner July 25, 2023 16:03
@daniellacosse
Copy link
Contributor Author

@fortuna since I'm editing previous IDs, without updating translations the footer should just revert to the old copy. Is that cool?

@daniellacosse
Copy link
Contributor Author

English:

Screenshot 2023-07-25 at 12 05 46

Spanish (falling back to old translation):
Screenshot 2023-07-25 at 12 05 35

fortuna
fortuna reviewed Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see the changes to the messages.
Perhaps also update the PR title to be clearer.

@daniellacosse daniellacosse changed the title chore(www): remove 'server manager' from error messaging chore(www): remove 'server manager' term from error messaging and update zero-state footer to point to the Manager Jul 25, 2023
@daniellacosse
Copy link
Contributor Author

I only see the changes to the messages. Perhaps also update the PR title to be clearer.

Apologies! Failed to push because my email settings were incorrect for some reason. Title updated as well.

@daniellacosse daniellacosse changed the title chore(www): remove 'server manager' term from error messaging and update zero-state footer to point to the Manager chore(www): improve error messaging and update zero-state footer to point to the Manager Jul 25, 2023
maddyhof
maddyhof approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@maddyhof maddyhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniellacosse daniellacosse merged commit 562f78d into master Jul 27, 2023
13 checks passed
@hilary-ops
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

@maddyhof maddyhof maddyhof approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniellacosse @hilary-ops @fortuna @maddyhof