-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(www): improve error messaging and update zero-state footer to point to the Manager #1662
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1662 +/- ##
========================================
+ Coverage 15% 45% +30%
========================================
Files 6 39 +33
Lines 806 1943 +1137
Branches 0 312 +312
========================================
+ Hits 121 885 +764
- Misses 685 1058 +373
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fortuna since I'm editing previous IDs, without updating translations the footer should just revert to the old copy. Is that cool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see the changes to the messages.
Perhaps also update the PR title to be clearer.
Apologies! Failed to push because my email settings were incorrect for some reason. Title updated as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
No description provided.