-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devtools): add warning to macos debug and document flag passthrough example #1661
Changes from 6 commits
599e6b3
c385d04
8f41d63
2470b9d
3ee8c7f
6b7d957
22ce333
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ import {getRootDir} from '../build/get_root_dir.mjs'; | |
import {runAction} from '../build/run_action.mjs'; | ||
import {getBuildParameters} from '../build/get_build_parameters.mjs'; | ||
import {spawnStream} from '../build/spawn_stream.mjs'; | ||
import chalk from 'chalk'; | ||
|
||
const WORKING_CORDOVA_OSX_COMMIT = '07e62a53aa6a8a828fd988bc9e884c38c3495a67'; | ||
|
||
|
@@ -140,6 +141,10 @@ async function appleMacOsDebug(verbose) { | |
throw new Error('Building an Apple binary requires xcodebuild and can only be done on MacOS'); | ||
} | ||
|
||
console.warn( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does debug mode work on Intel? If so, perhaps we output this only for non-intel There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, it's on everything :/ Because |
||
chalk.yellow('Debug mode on the MacOS client is currently broken. Try running with `--buildMode=release` instead.') | ||
); | ||
|
||
await cordova.platform('add', [`github:apache/cordova-osx#${WORKING_CORDOVA_OSX_COMMIT}`], {save: false}); | ||
|
||
await cordova.prepare({ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I added a command to the Apple readme that people can copy and past as-is: https://github.com/Jigsaw-Code/outline-client/blob/fortuna-readme/src/cordova/apple/README.md#set-up-xcode-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!