fix(devtools): add warning to macos debug and document flag passthrough example #1661
Conversation
daniellacosse
changed the title
daniellacosse
changed the title
…aw-Code/outline-client into daniellacosse/macos-warning
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1661 +/- ##
=======================================
+ Coverage 36% 45% +9%
=======================================
Files 45 39 -6
Lines 2756 1943 -813
Branches 312 312
=======================================
- Hits 1006 885 -121
+ Misses 1750 1058 -692
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| ); | ||
| } | ||
|
|
||
| console.warn( |
There was a problem hiding this comment.
Does debug mode work on Intel? If so, perhaps we output this only for non-intel
There was a problem hiding this comment.
No, it's on everything :/ Because console.assert is bugged on the deprecated web view
Co-authored-by: Vinicius Fortuna <[email protected]>
| Certain actions take configuration flags - but since we're running them through `npm`, you'll have to use the `--` seperator to funnel them through to the underlying process. For example, to set up a MacOS project in release mode, you'd run: | ||
|
|
||
| ```sh | ||
| SENTRY_DSN=<your sentry dsn> npm run action cordova/setup macos -- --buildMode=release --versionName=<your version name> |
There was a problem hiding this comment.
FYI, I added a command to the Apple readme that people can copy and past as-is: https://github.com/Jigsaw-Code/outline-client/blob/fortuna-readme/src/cordova/apple/README.md#set-up-xcode-project
No description provided.