Fix issue 3370

screen/contributors/src/main/java/com/ivy/contributors/ContributorsViewModel.kt

@@ -49,22 +49,18 @@ class ContributorsViewModel @Inject constructor(
     }
 
     private suspend fun fetchContributors() {
-        val contributors = ivyWalletRepositoryDataSource.fetchContributors()?.map {
+        val contributors = ivyWalletRepositoryDataSource.fetchContributors().map {
             Contributor(
-                name = it.login,
-                photoUrl = it.avatarUrl,
+                name = it.login ?: "Anonymous",
+                photoUrl = it.avatarUrl ?: "",
                 contributionsCount = it.contributions.toString(),
-                githubProfileUrl = it.link
+                githubProfileUrl = it.link ?: ""
             )
         }
 
-        if (contributors != null) {
-            contributorsResponse.value = ContributorsResponse.Success(
-                contributors.toImmutableList()
-            )
-        } else {
-            contributorsResponse.value = ContributorsResponse.Error("Error")
-        }
+        contributorsResponse.value = ContributorsResponse.Success(
+            contributors.toImmutableList()
+        )
     }
 
     private suspend fun fetchProjectInfo() {

screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt

@@ -9,6 +9,7 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
+import timber.log.Timber
 import javax.inject.Inject
 
 class IvyWalletRepositoryDataSource @Inject constructor(
@@ -17,12 +18,12 @@ class IvyWalletRepositoryDataSource @Inject constructor(
     @Keep
     @Serializable
     data class ContributorDto(
-        val login: String,
+        val login: String? = null,
         @SerialName("avatar_url")
-        val avatarUrl: String,
+        val avatarUrl: String? = null,
         val contributions: Int,
         @SerialName("html_url")
-        val link: String
+        val link: String? = null,
     )
 
     @Keep
@@ -38,19 +39,48 @@ class IvyWalletRepositoryDataSource @Inject constructor(
 
     companion object {
         private const val CONTRIBUTORS_PER_PAGE = 100
+        private const val DISPLAY_ANONYMOUS_CONTRIBUTORS = true
+        private const val INITIAL_PAGE = 1
     }
 
-    suspend fun fetchContributors(): List<ContributorDto>? {
-        return try {
-            withContext(Dispatchers.IO) {
+    suspend fun fetchContributors(): List<ContributorDto> {
+        return withContext(Dispatchers.IO) {
+            val contributors = mutableListOf<ContributorDto>()
+            paging(addContributors = { results ->
+                results?.forEach { contributor -> contributors.add(contributor) }
+            })
+            contributors.toList()
+        }
+    }
+
+    private suspend fun paging(addContributors: (List<ContributorDto>?) -> Unit) {
+        var currentPage: Int? = INITIAL_PAGE
+        while (currentPage != null) {
+            val contributors = try {
                 httpClient
                     .get("https://api.github.com/repos/Ivy-Apps/ivy-wallet/contributors") {
+                        parameter("anon", DISPLAY_ANONYMOUS_CONTRIBUTORS)
                         parameter("per_page", CONTRIBUTORS_PER_PAGE)
+                        parameter("page", currentPage)
                     }
                     .body<List<ContributorDto>>()
+            } catch (e: Exception) {
+                Timber.tag("FETCH_CONTRIBUTORS").d(e)
+                null
             }
-        } catch (e: Exception) {
+            currentPage = getCurrentPage(contributors, currentPage)
+            currentPage?.let { addContributors(contributors) }
+        }
+    }
+
+    private fun getCurrentPage(
+        contributors: List<ContributorDto>?,
+        currentPage: Int
+    ): Int? {
+        return if (contributors?.isEmpty() == true) {
             null
+        } else {
+            currentPage + 1
         }
     }
 

screen/contributors/src/test/java/com/ivy/contributors/ContributorsViewModelTest.kt

@@ -78,7 +78,7 @@ class ContributorsViewModelTest : ComposeViewModelTest() {
     @Test
     fun `unhappy path, both error`() {
         // given
-        coEvery { repoDataSource.fetchContributors() } returns null
+        coEvery { repoDataSource.fetchContributors() } returns emptyList()
         coEvery { repoDataSource.fetchRepositoryInfo() } returns null
 
         viewModel.runTest {