-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 3370 #3381
Fix issue 3370 #3381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Left some comments, add unit tests (if possible), fix the CI and we can merge it
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/ContributorsViewModel.kt
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments. Thanks for migrating it to FP-style and Arrow!
screen/contributors/src/main/java/com/ivy/contributors/ContributorsViewModel.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/test/java/com/ivy/contributors/ContributorsViewModelTest.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/test/java/com/ivy/contributors/ContributorsViewModelTest.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
My pleasure! I’ll study this concept further |
screen/contributors/src/test/java/com/ivy/contributors/datasource/ContributorsDataSourceTest.kt
Outdated
Show resolved
Hide resolved
@rodrigoliveirac also make sure to check this:
|
@ILIYANGERMANOV To avoid unnecessary complexity, I’ve decided to leave this test unimplemented for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about incorrect Arrow usages. Ping me to merge after they are resolved and the CI has passed
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/ContributorsViewModel.kt
Outdated
Show resolved
Hide resolved
screen/contributors/src/main/java/com/ivy/contributors/IvyWalletRepositoryDataSource.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👏 LGTM!
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of interacting with your changes:
What's changed?
Describe with a few bullets what's new:
per_page
parameter. We are now also using thepage
parameter for pagination and including anonymous contributors with theanon
parameter.Risk factors
What may go wrong if we merge your PR?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.