Fix building with -DBUILD_EASYLOGGINGPP=OFF #11962
Conversation
.github/workflows/buildsCI.yaml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
|
|
|||
|
|
|||
| #-------------------------------------------------------------------------------- | |||
| Win_SH_EX_CfU: # Windows, shared, with Examples & Tools, and Check for Updates | |||
| Win_SH_EX_CfU: # Windows, shared, with Examples & Tools, no EasyLogging and Check for Updates | |||
There was a problem hiding this comment.
Don't we also need to check on Linux?
There was a problem hiding this comment.
Since it's at the application level I thought it's enough to test on 1 OS, you think Linux is needed too?
We can add..
|
Why did we also change terminal-parser? |
When you added #include <rsutils/string/from.h> you removed the iostream include. It worked because easylogging include it somewhere, without it it was missing and we don't check it so you missed it. I checked and the cout was redundant, so instead of reverting the removal of include iostream, I removed the cout. |
How is it redundant? I don't see other code that outputs it... |
Nir-Az
force-pushed
the
fix_ezlog
branch
3 times, most recently
from
7ce9ec6
to
1c5167d
Compare
Fix #11905
Tracked on [LRS-829]