Build error when disabling easylogging

[GrubbyHalo]

SDK Version 2.54.1

If I disable easylogging i get the following build error using gcc10

src/librealsense/src/terminal-parser.cpp: In member function ‘std::vector<unsigned char> librealsense::terminal_parser::parse_command(const string&) const’:
src/librealsense/src/terminal-parser.cpp:37:13: error: ‘cout’ was not declared in this scope
   37 |             cout << hex << fixed << setfill('0') << setw(2) << (int)b << " ";
      |             ^~~~
src/librealsense/src/terminal-parser.cpp:5:1: note: ‘std::cout’ is defined in header ‘<iostream>’; did you forget to ‘#include <iostream>’?

maybe specifically include in terminal-parser.cpp ?

[MartyG-RealSense]

Hi @GrubbyHalo Have you experienced this issue in the previous SDKs 2.53.1 or 2.51.1?

The most recent change to easylogging that is listed in the SDK release notes is 'Add easylogging include cmake' in SDK 2.51.1 - see #10388

[GrubbyHalo]

I haven't tested previous releases. This is the first time I have disabled easylogging, with release 2.54.1 I'm assuming that in the presence of easylogging that is brought into the include list for terminal-parser among its dependencies and that in its absence it isn't ?

[MartyG-RealSense]

There were previously problems with -DBUILDEASYLOGGINGPP=OFF in 2020 but this was fixed by an update to the SDK, as described at #7554 and there have not been reports of problems with easylogging since then. Looking at the history of this support forum, it looks as though this flag is very rarely used and so you could likely use the SDK fine without setting this flag to off.

In regard to your question about the workings of easylogging, I don't know the answer to that.

[GrubbyHalo]

I noticed that the fix you refered to included the missing include file. subsequent to that it was removed again about 6 months ago in this commit. (Compare that commit and the one just before it)

[MartyG-RealSense]

I will highlight your finding about a missing include file to my Intel RealSense colleagues to seek their advice.

[MartyG-RealSense]

Hi @GrubbyHalo Thanks very much for your patience. My Intel RealSense colleagues were able to replicate your problem with easylogging=off and will discuss it. As you said, it is due to an earlier removal of an include. Thanks again for your report of the issue!

[Nir-Az]

Fix merged : #11962

[MartyG-RealSense]

Hi @GrubbyHalo As a fix for the easylogging=off issue was merged into the RealSense SDK last week - see #11962 - do you require further assistance with this case, please? Thanks!

[GrubbyHalo]

No further assistance required thanks.

[MartyG-RealSense]

Thanks very much for the update!