Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

[DON'T MERGE]Ignore the default_display_window_flag in the SPS parsing. #2928

Open
wants to merge 1 commit into
base: mss2018_r2
Choose a base branch
from
Open

[DON'T MERGE]Ignore the default_display_window_flag in the SPS parsing. #2928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion _studio/shared/umc/codec/h265_dec/src/umc_h265_bitstream_headers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,9 @@ void H265HeadersBitstream::parseVUI(H265SeqParamSet *pSPS)
pSPS->frame_field_info_present_flag = Get1Bit();

pSPS->default_display_window_flag = Get1Bit();
if (pSPS->default_display_window_flag)
//Hack to ignore the video cropping here.
//if (pSPS->default_display_window_flag)
if (0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (0) is not good coding. And could you please explain the reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for a manual build, will not check in.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add [DO NOT MERGE] at the title of PR and commit for avoiding misunderstanding. Thanks.

{
pSPS->def_disp_win_left_offset = GetVLCElementU()*pSPS->SubWidthC();
pSPS->def_disp_win_right_offset = GetVLCElementU()*pSPS->SubWidthC();
Expand Down