This repository has been archived by the owner on May 17, 2023. It is now read-only.
[DON'T MERGE]Ignore the default_display_window_flag in the SPS parsing. #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyan-intel
suggested changes
May 13, 2022
| if (pSPS->default_display_window_flag) | ||
| //Hack to ignore the video cropping here. | ||
| //if (pSPS->default_display_window_flag) | ||
| if (0) |
There was a problem hiding this comment.
if (0) is not good coding. And could you please explain the reason?
There was a problem hiding this comment.
Just for a manual build, will not check in.
There was a problem hiding this comment.
Please add [DO NOT MERGE] at the title of PR and commit for avoiding misunderstanding. Thanks.
hongbolv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.