Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose vault controls for any share, loot or delegated share holder. … #355

Merged
merged 2 commits into from
Jul 26, 2023
Merged

expose vault controls for any share, loot or delegated share holder. … #355

merged 2 commits into from
Jul 26, 2023

Conversation

dekanbro
Copy link
Contributor

… Also fail with a 'NA' when safe api returns 503

GitHub Issue

NA
this was reported in tg
example DAO
https://admin.daohaus.fun/#/molochv3/0x1/0x81db04dfd741a765eae4696643c3bb558e7ac3b4/safes

image

Checks

Before making your PR, please check the following:

  • [ X] Critical lint errors are resolved
  • [ X] App runs locally
  • [ X] App builds locally (run the build command for any impacted package and check for any errors before the PR)

@dekanbro dekanbro requested a review from skuhlmann July 25, 2023 18:29
@shayanb shayanb mentioned this pull request Jul 25, 2023
Closed
4 tasks
@dekanbro
Copy link
Contributor Author

#358 and #357

@dekanbro dekanbro marked this pull request as ready for review July 25, 2023 20:10
@skuhlmann skuhlmann merged commit 3941848 into develop Jul 26, 2023
1 check passed
@skuhlmann skuhlmann deleted the feat/vaultDelegateControls branch August 23, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuhlmann skuhlmann skuhlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dekanbro @skuhlmann