Check before creating by_assembly directories #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng by_species directory exists
apriltuesday
approved these changes
Jul 17, 2024
| # Create a link from assembly folder to species_folder ex: by_assembly/GCA_000005005.5/zea_mays to by_species/zea_mays/GCA_000005005.5 | ||
| create_symlink_to_species_folder_from_assembly_folder(current_release_assembly_info, release_properties, | ||
| public_release_assembly_folder) | ||
| if current_release_assembly_info["num_rs_to_release"] > 0: |
There was a problem hiding this comment.
Debatable whether this is even a good idea, but elsewhere we check both num_rs_to_release and should_be_released... should we do the same here to be consistent?
There was a problem hiding this comment.
I think you're right that this is inconsistent with what is done elsewhere.
The reason I've only used the num_rs_to_release is because originally the should_be_released flag really meant that the release pipeline should be run not that the data should be copied and in previous version of the release automation should_be_released=false and num_rs_to_release>0 was used to denote release that had not changed since the previous release and could be hard-linked.
eva-accession-release-automation/publish_release_to_ftp/publish_release_files_to_ftp.py
Outdated
Show resolved
Hide resolved
nitin-ebi
approved these changes
Jul 18, 2024
…h_release_files_to_ftp.py Co-authored-by: April Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only create a symlink in the by assembly directory if the corresponding by_species directory exists