-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass data as an option #218
Merged
Merged
Commits on Jun 20, 2023
-
Put
AlgorithmTypes
tuple into algorithm_types.hThis brings the tuple and the enum closer together to avoid confusion, like in Desbordante#209
Configuration menu - View commit details
-
Copy full SHA for b91c733 - Browse repository at this point
Copy the full SHA b91c733View commit details
Commits on Jun 26, 2023
-
Use simpler types in python bindings
`pybind11::object` manages reference counting, which is sometimes unneeded. Also changes some `std::string` to `std::string_view`.
Configuration menu - View commit details
-
Copy full SHA for 176a925 - Browse repository at this point
Copy the full SHA 176a925View commit details -
Return
frozenset
of type tuples inGetPyType
Allows to denote when multiple types can be accepted.
Configuration menu - View commit details
-
Copy full SHA for 6a5cc45 - Browse repository at this point
Copy the full SHA 6a5cc45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b4065f - Browse repository at this point
Copy the full SHA 2b4065fView commit details -
The files are structured this way because an algorithm may use several tables (HyMD) or even a list of tables (Spider). Those algorithms still need the `InputTable` type, but they will register different options, which may become common later and will thus be put in this directory as well.
Configuration menu - View commit details
-
Copy full SHA for ecd0a8e - Browse repository at this point
Copy the full SHA ecd0a8eView commit details -
Also includes some minor test rewrites. Makes it easier to implement algorithms that take something other than a single table.
Configuration menu - View commit details
-
Copy full SHA for 7393e6c - Browse repository at this point
Copy the full SHA 7393e6cView commit details
Commits on Jul 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9892863 - Browse repository at this point
Copy the full SHA 9892863View commit details -
Configuration menu - View commit details
-
Copy full SHA for 132f224 - Browse repository at this point
Copy the full SHA 132f224View commit details -
Use column schema in
FDAlgorithm::GetKeys
Uses a more robust way of getting the number of columns. Avoids the reliance on `input_table_` being set to the table being processed now, indirectly inherited from the old implementation. Previously, there was a possibility that `input_table_` would not be set to the table being processed in `PliBasedFdAlgorithm` because of its `LoadData` overload, but the only scenario which used it was using `TypoMiner`, and that class would always set the option correctly.
Configuration menu - View commit details
-
Copy full SHA for 551a2ce - Browse repository at this point
Copy the full SHA 551a2ceView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.