Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass data as an option #218

Merged
merged 9 commits into from
Jul 1, 2023
Merged

Pass data as an option #218

merged 9 commits into from
Jul 1, 2023

Commits on Jun 20, 2023

  1. Put AlgorithmTypes tuple into algorithm_types.h

    This brings the tuple and the enum closer together to avoid confusion,
    like in Desbordante#209
    BUYT-1 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b91c733 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Use simpler types in python bindings

    `pybind11::object` manages reference counting, which is sometimes
    unneeded. Also changes some `std::string` to `std::string_view`.
    BUYT-1 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    176a925 View commit details
    Browse the repository at this point in the history
  2. Return frozenset of type tuples in GetPyType

    Allows to denote when multiple types can be accepted.
    BUYT-1 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    6a5cc45 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2b4065f View commit details
    Browse the repository at this point in the history
  4. Add "table" option

    The files are structured this way because an algorithm may use several
    tables (HyMD) or even a list of tables (Spider).
    Those algorithms still need the `InputTable` type, but they will
    register different options, which may become common later and will thus
    be put in this directory as well.
    BUYT-1 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ecd0a8e View commit details
    Browse the repository at this point in the history
  5. Pass data as an option

    Also includes some minor test rewrites. Makes it easier to implement
    algorithms that take something other than a single table.
    BUYT-1 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    7393e6c View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Configuration menu
    Copy the full SHA
    9892863 View commit details
    Browse the repository at this point in the history
  2. Rename kData to kCsvPath

    BUYT-1 committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    132f224 View commit details
    Browse the repository at this point in the history
  3. Use column schema in FDAlgorithm::GetKeys

    Uses a more robust way of getting the number of columns. Avoids the
    reliance on `input_table_` being set to the table being processed now,
    indirectly inherited from the old implementation. Previously, there was
    a possibility that `input_table_` would not be set to the table being
    processed in `PliBasedFdAlgorithm` because of its `LoadData` overload,
    but the only scenario which used it was using `TypoMiner`, and that
    class would always set the option correctly.
    BUYT-1 committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    551a2ce View commit details
    Browse the repository at this point in the history