Pass data as an option #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BUYT-1
force-pushed
the
data-as-option
branch
6 times, most recently
from
f36d73b
to
c8ef7b3
Compare
BUYT-1
force-pushed
the
data-as-option
branch
15 times, most recently
from
dc2923d
to
5721d0a
Compare
polyntsov
requested changes
Jun 18, 2023
This brings the tuple and the enum closer together to avoid confusion, like in Desbordante#209
BUYT-1
force-pushed
the
data-as-option
branch
2 times, most recently
from
1c0b878
to
6571177
Compare
polyntsov
requested changes
Jun 25, 2023
`pybind11::object` manages reference counting, which is sometimes unneeded. Also changes some `std::string` to `std::string_view`.
Allows to denote when multiple types can be accepted.
The files are structured this way because an algorithm may use several tables (HyMD) or even a list of tables (Spider). Those algorithms still need the `InputTable` type, but they will register different options, which may become common later and will thus be put in this directory as well.
Also includes some minor test rewrites. Makes it easier to implement algorithms that take something other than a single table.
BUYT-1
force-pushed
the
data-as-option
branch
2 times, most recently
from
24ba80c
to
b054296
Compare
polyntsov
reviewed
Jul 1, 2023
Uses a more robust way of getting the number of columns. Avoids the reliance on `input_table_` being set to the table being processed now, indirectly inherited from the old implementation. Previously, there was a possibility that `input_table_` would not be set to the table being processed in `PliBasedFdAlgorithm` because of its `LoadData` overload, but the only scenario which used it was using `TypoMiner`, and that class would always set the option correctly.
polyntsov
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to implement algorithms that accept anything other than a table.