Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iast): report telemetry log error [backport 2.14] #10784

Merged
merged 1 commit into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. feat(iast): report telemetry log error (#10740)

    Always report a telemetry log error when an IAST propagation error
    raises, regardless of whether the `_DD_IAST_DEBUG` environment variable
    is enabled or not.
    
    - Fix some side effects of aspect functions in join_aspect, ljust_aspect
    - Fix `format_aspect` "if not..." side-effect
    - Fix `format_map_aspect` not BuiltinFunctionType
    - Early fail in `decode/encode_aspect`
    ## Checklist
    - [x] PR author has checked that all the criteria below are met
    - The PR description includes an overview of the change
    - The PR description articulates the motivation for the change
    - The change includes tests OR the PR description describes a testing
    strategy
    - The PR description notes risks associated with the change, if any
    - Newly-added code is easy to change
    - The change follows the [library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    - The change includes or references documentation updates if necessary
    - Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    
    ## Reviewer Checklist
    - [ ] Reviewer has checked that all the criteria below are met
    - Title is accurate
    - All changes are related to the pull request's stated goal
    - Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes
    - Testing strategy adequately addresses listed risks
    - Newly-added code is easy to change
    - Release note makes sense to a user of the library
    - If necessary, author has acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment
    - Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    
    (cherry picked from commit e237d91)
    avara1986 authored and github-actions[bot] committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    aa80e16 View commit details
    Browse the repository at this point in the history