Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iast): report telemetry log error [backport 2.14] #10784

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport e237d91 from #10740 to 2.14.

Always report a telemetry log error when an IAST propagation error raises, regardless of whether the _DD_IAST_DEBUG environment variable is enabled or not.

  • Fix some side effects of aspect functions in join_aspect, ljust_aspect
  • Fix format_aspect "if not..." side-effect
  • Fix format_map_aspect not BuiltinFunctionType
  • Fix _aspect_split error task APPSEC-54782
  • Early fail in decode/encode_aspect

Jira Task: APPSEC-54993

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Always report a telemetry log error when an IAST propagation error
raises, regardless of whether the `_DD_IAST_DEBUG` environment variable
is enabled or not.

- Fix some side effects of aspect functions in join_aspect, ljust_aspect
- Fix `format_aspect` "if not..." side-effect
- Fix `format_map_aspect` not BuiltinFunctionType
- Early fail in `decode/encode_aspect`
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit e237d91)
@github-actions github-actions bot requested review from a team as code owners September 24, 2024 17:00
@github-actions github-actions bot added the ASM Application Security Monitoring label Sep 24, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Benchmarks

Benchmark execution time: 2024-09-24 17:41:38

Comparing candidate commit aa80e16 in PR branch backport-10740-to-2.14 with baseline commit d4a7535 in branch 2.14.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

@avara1986 avara1986 merged commit 3acd4e7 into 2.14 Sep 25, 2024
451 of 452 checks passed
@avara1986 avara1986 deleted the backport-10740-to-2.14 branch September 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants