Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foodcritic errors #541

Open
jjasghar opened this issue Apr 16, 2018 · 1 comment
Open

Foodcritic errors #541

jjasghar opened this issue Apr 16, 2018 · 1 comment

Comments

@jjasghar
Copy link 

FC079: Deprecated easy_install_package resource usage: ./recipes/ddtrace-python.rb:9
FC113: Resource declares deprecated use_inline_resources: ./providers/monitor.rb:4

#539

Can yall either accept these style differences and ignore them or resolve it?

/cc @russellseymour
@jjasghar
Copy link
Author 

[datadog-cookbook] $ /bin/bash /tmp/jenkins7673545352440283996.sh
Checking 144 files
........x....................................x..................................................................................................
FC079: Deprecated easy_install_package resource usage: ./recipes/ddtrace-python.rb:9
FC113: Resource declares deprecated use_inline_resources: ./providers/monitor.rb:4
Build step 'Execute shell' marked build as failure
Finished: FAILURE

@jeffbyrnes jeffbyrnes mentioned this issue Oct 10, 2018
Closed
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this issue Oct 10, 2018
@jeffbyrnes
Replace easy_install resource with python_package
a34cbec 
Adds a dependency on poise-python.

Fixes DataDog#539

Relates to DataDog#541
@jeffbyrnes jeffbyrnes mentioned this issue Oct 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjasghar