Refactor datadog_monitor LWRP into Custom Resource #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Change This sets the required Chef version to Chef >= 12.5, as indicated in metadata.
|
Thanks @jeffbyrnes for opening this PR, most of its content is addressed in #450 so I'll merge that one first and incorporate some of your changes on top of it. |
|
@olivielpeau dang, not sure how I missed that. Sounds good! |
|
@olivielpeau for my own sake, and just generally tidiness, I’m going to close this out. Please, of course, feel free to pick out bits that make sense to add/layer on top of #450. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
This sets the required Chef version to Chef >= 12.5, as indicated in metadata.
Handles some of what is reported in #541