Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace easy_install resource with python_package #567

Closed

Conversation

jeffbyrnes
Copy link
Contributor

Adds a dependency on poise-python.

Fixes #539

Relates to #541

Adds a dependency on poise-python.

Fixes DataDog#539

Relates to DataDog#541
@olivielpeau olivielpeau added this to the 2.17.0 milestone Oct 29, 2018
@olivielpeau
Copy link
Member

I'd like to avoid adding a dependency on a new cookbook in order to only provide this recipe:

  • maintaining cookbook dependencies/version constraints over time is always a bit tricky (for example see all the "recommendation" notes in metadata.rb and in the README), and
  • I feel the use case of installing the ddtrace pip package could be more easily addressed by documenting it in the README

Instead, I'd prefer deprecating the ddtrace-python recipe in datadog 2.17 , and remove it in 3.0 (while documenting how to use poise-python to achieve the same purpose). What do you think?

@jeffbyrnes
Copy link
Contributor Author

@olivielpeau I think that’s reasonable! I think it’s probably out-of-scope for me to tackle a deprecation in a cookbook I don’t maintain directly, so I’ll close this & leave that to you.

@jeffbyrnes jeffbyrnes closed this Oct 29, 2018
@jeffbyrnes jeffbyrnes deleted the replace-easy_install-resource branch September 8, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants