Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed product description showing up instead of name in two locations #957

Merged
merged 1 commit into from
May 22, 2024

Conversation

kenshin133
Copy link
Sponsor

@kenshin133 kenshin133 commented May 22, 2024

This seems to be referenced two places, admin/servers and admin/users/1

I could not find any other effects of this change but do feel free to double check my work.

themes/default/views/admin/servers/table.blade.php
And
themes/default/views/admin/users/show.blade.php
and perhaps
themes/default/views/admin/users/edit.blade.php

have
data: 'resources', name: 'product.name',

In them, another fix would be to alter this to data: 'product.name' but the proposed change seems like the right one.

This seems to be referenced two places, admin/servers and admin/users/1

I could not find any other effects of this change but do feel free to double check my work.

themes/default/views/admin/servers/table.blade.php
And
themes/default/views/admin/users/show.blade.php
and perhaps
themes/default/views/admin/users/edit.blade.php

have
data: 'resources', name: 'product.name',

In them, another fix would be to alter this to data: 'product.name' but the proposed change seems like the right one.
@S0ly S0ly added Bug / Fix Something isn't working and may need a fix High Priority Critical. Act quickly for resolution labels May 22, 2024
@S0ly S0ly linked an issue May 22, 2024 that may be closed by this pull request
@S0ly
Copy link
Member

S0ly commented May 22, 2024

Please don’t forget to correctly configure your PR

Is this PR ready for review or you forgot to put it in draft mode ?

@S0ly
Copy link
Member

S0ly commented May 22, 2024

And don’t make commit that long 😂 add a comment here if needed

@S0ly
Copy link
Member

S0ly commented May 22, 2024

But other than that it’s fine :) thanks for the fix !

@kenshin133
Copy link
Sponsor Author

kenshin133 commented May 22, 2024

Sorry, thought that was for the pull, I dont see a way to edit it, the code is ready.

Thank you kindly for reviewing.

@S0ly
Copy link
Member

S0ly commented May 22, 2024

Don’t worry you seems new :D and we don’t have good contributing guidelines for the moment

For me the change seems fine but I would like someone else to check it since I’m confused by what need to be shown

@MrWeez
Copy link
Collaborator

MrWeez commented May 22, 2024

Don’t worry you seems new :D and we don’t have good contributing guidelines for the moment

For me the change seems fine but I would like someone else to check it since I’m confused by what need to be shown

I'll check it out when I get home.

@S0ly
Copy link
Member

S0ly commented May 22, 2024

Thanks tell me if it’s good ;)

@MrWeez
Copy link
Collaborator

MrWeez commented May 22, 2024

Thanks tell me if it’s good ;)

Yep, everything works. You can merge this PR

@S0ly S0ly merged commit 396d255 into Ctrlpanel-gg:development May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix Something isn't working and may need a fix High Priority Critical. Act quickly for resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect display of the product on the user's viewing page / v0.10
3 participants