[Bug]: Incorrect display of the product on the user's viewing page / v0.10

[MrWeez]

What is your request about?

The server product name is displayed incorrectly on the /admin/users/<user_id> page. The error is like in this issue, but in a different place.

Branch

development

Solution idea

No response

Controlpanel Logs

No response

Additional Info

[S0ly]

im confused where do you see it display incorrectly ?
because the name is here maybe because it says product and not description ?

[MrWeez]

im confused where do you see it display incorrectly ? because the name is here maybe because it says product and not description ?

It displays the description of the product, not its name. This problem was elsewhere, I attached a link in the message above.

[S0ly]

yes but the name is not already here ?

[MrWeez]

yes but the name is not already here ?

This is the name of the server, not its product

[S0ly]

ho okay I'm still confused xD I will add it to the panel fix branch

[kenshin133]

To show this more clearly,
Here is the product :

and here is under my user (this is in main branch.. but the issue is not new)

You will see under "config" (Which is now "product" in .10) It says "description1" when it should say "name1"

[S0ly]

hooo okay

[kenshin133]

Checked into this a bit, in admin/users/show.blade.php which seems to be the right location for this, the datatables are calling the right thing:
{
data: 'resources',
name: 'product.name'
},

            In database product.name is correct. Will check into this a bit more. 

[kenshin133]

I figured out the fix, but dont know why it works so someone else needs to follow up on this one.

The change is line 231 of app/Http/Controllers/Admin/ServerController.php

Changed from "return $server->product->description;"

to "return $server->product->name;"

[S0ly]

If you get the description in’s tread of the name your fix make sense

[kenshin133]

The fix makes sense and that's how I found it, but I'm not 100% sure this value isn't used elsewhere.

So I've posted in hopes someone else quickly gives it a pass or fail when they get around to it. its a pretty minor issue. (and possibly up to preference)

[kenshin133]

#957 may fix this

[MrWeez]

@S0ly can you link the issue to the PR? Thx.

[S0ly]

@MrWeez yes thanks, ask @1day2die for permission so you can do it 😅