Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm maintainence #125

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Aug 21, 2023

Local dev with ember-velcro inherently causes unrelated changes without a few tweaks here

  • use volta
  • update ci to use volta-aware and pnpm-cache-aware action
  • reduceLock

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

⚠️ No Changeset found

Latest commit: b8e0e2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NullVoxPopuli NullVoxPopuli mentioned this pull request Aug 21, 2023
@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Aug 21, 2023

Demo in my fork: https://github.com/NullVoxPopuli/ember-velcro/actions/runs/5927151629/job/16070051303
(failures are from the work in here: #124 )

I need to fix that on #124

@ynotdraw ynotdraw merged commit c8434c1 into CrowdStrike:main Aug 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants