Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transform #124

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Remove transform #124

merged 10 commits into from
Aug 23, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Aug 21, 2023

Resolves: #122

Additional context: universal-ember/ember-primitives#89

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

🦋 Changeset detected

Latest commit: d3efa09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-velcro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pnpm-lock.yaml Outdated
@@ -1,5 +1,9 @@
lockfileVersion: '6.0'

settings:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this repo is behind on pnpm updates -- Separate PR incoming

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Aug 21, 2023

Blocked on: #125

Here is evidence of all the other PRs together working to get green status: https://github.com/NullVoxPopuli/ember-velcro/actions/runs/5927225971/job/16070301274

I'll be moving forward with my own dist branch: https://github.com/NullVoxPopuli/ember-velcro/tree/dist
in the mean time 🥳

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review August 21, 2023 13:38
@NullVoxPopuli NullVoxPopuli mentioned this pull request Aug 21, 2023
@ynotdraw
Copy link
Contributor

I think a rebase may resolve the conflicts now

@ynotdraw ynotdraw merged commit c3a4b7b into CrowdStrike:main Aug 23, 2023
18 checks passed
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
@NullVoxPopuli NullVoxPopuli deleted the remove-transform branch August 24, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible with the <dialog> element
2 participants