Feature/remove is filled for fun

account/api/serializers.py

@@ -44,7 +44,6 @@ class Meta:
             "year_of_birth",
             "postal_code",
             "optional_postal_code",
-            "is_filled_for_fun",
             "is_interested_in_mobility",
             "result_can_be_used",
             "gender",

account/migrations/0014_remove_profile_is_filled_for_fun.py

@@ -0,0 +1,17 @@
+# Generated by Django 4.1.13 on 2024-04-11 06:37
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("account", "0013_user_has_subscribed"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="profile",
+            name="is_filled_for_fun",
+        ),
+    ]

account/models.py

@@ -46,7 +46,6 @@ class Profile(models.Model):
     year_of_birth = models.PositiveSmallIntegerField(null=True, blank=True)
     postal_code = models.CharField(max_length=10, null=True)
     optional_postal_code = models.CharField(max_length=10, null=True)
-    is_filled_for_fun = models.BooleanField(default=False)
     is_interested_in_mobility = models.BooleanField(default=False)
     result_can_be_used = models.BooleanField(default=True)
     gender = models.CharField(

account/tests/test_api.py

@@ -123,7 +123,6 @@ def test_profile_put(api_client_authenticated, users, profiles):
     user = users.get(username="test1")
     url = reverse("account:profiles-detail", args=[user.id])
     assert user.profile.is_interested_in_mobility is False
-    assert user.profile.is_filled_for_fun is False
     assert user.profile.gender is None
     assert user.profile.postal_code is None
     assert user.profile.optional_postal_code is None
@@ -133,14 +132,12 @@ def test_profile_put(api_client_authenticated, users, profiles):
         "optional_postal_code": "20220",
         "is_interested_in_mobility": True,
         "gender": "F",
-        "is_filled_for_fun": True,
         "result_can_be_used": False,
     }
     response = api_client_authenticated.put(url, data)
     assert response.status_code == 200
     user.refresh_from_db()
     assert user.profile.is_interested_in_mobility is True
-    assert user.profile.is_filled_for_fun is True
     assert user.profile.gender == "F"
     assert user.profile.postal_code == "20210"
     assert user.profile.optional_postal_code == "20220"
@@ -206,16 +203,6 @@ def test_profile_patch_year_of_birth(api_client_authenticated, users, profiles):
     assert user.profile.year_of_birth == 42
 
 
-@pytest.mark.django_db
-def test_profile_patch_is_filled_for_fun(api_client_authenticated, users, profiles):
-    user = users.get(username="test1")
-    url = reverse("account:profiles-detail", args=[user.id])
-    assert user.profile.is_filled_for_fun is False
-    patch(api_client_authenticated, url, {"is_filled_for_fun": True})
-    user.refresh_from_db()
-    assert user.profile.is_filled_for_fun is True
-
-
 @pytest.mark.django_db
 def test_profile_patch_result_can_be_used(api_client_authenticated, users, profiles):
     user = users.get(username="test1")

profiles/api/views.py

@@ -115,11 +115,7 @@ def question_condition_met(question_condition_qs, user):
 def update_postal_code_result(user):
     # Ensure that duplicate results are not saved, profiles filled for fun and profiles whos result
     # can not be used are ignored.
-    if (
-        user.postal_code_result_saved
-        or user.profile.is_filled_for_fun
-        or not user.profile.result_can_be_used
-    ):
+    if user.postal_code_result_saved or not user.profile.result_can_be_used:
         return
     if user.result:
         result = user.result

profiles/tests/api/test_question.py

@@ -374,29 +374,6 @@ def test_get_question_by_numbers(api_client, questions):
     assert response.json()["results"][-1]["number"] == questions.last().number
 
 
-@pytest.mark.django_db
-def test_result_count_is_filled_for_fun_is_false(
-    api_client_authenticated, answers, users
-):
-    user = users.get(username="test1")
-    assert user.profile.is_filled_for_fun is False
-    url = reverse("profiles:question-end-poll")
-    response = api_client_authenticated.post(url)
-    assert response.status_code == 200
-    assert PostalCodeResult.objects.count() == 2
-
-
-@pytest.mark.django_db
-def test_result_count_is_filled_for_fun_is_true(api_client_authenticated, users):
-    user = users.get(username="test1")
-    url = reverse("profiles:question-end-poll")
-    user.profile.is_filled_for_fun = True
-    user.profile.save()
-    response = api_client_authenticated.post(url)
-    assert response.status_code == 200
-    assert PostalCodeResult.objects.count() == 0
-
-
 @pytest.mark.django_db
 def test_result_count_result_can_be_used_is_true(
     api_client_authenticated, users, answers