Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove is filled for fun #51

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Feature/remove is filled for fun #51

merged 4 commits into from
Apr 11, 2024

Conversation

juuso-j
Copy link
Collaborator

@juuso-j juuso-j commented Apr 11, 2024

Remove field is_filled_for_fun from profile model

Description

Trello #100

Breakdown:

API

  1. account/api/serializers.py
    • Remove field is_filled_for_fun
  2. profiles/api/views.py
    • Remove is_filled_for_fun check in update_postal_code_result

Model

  1. account/migrations/0014_remove_profile_is_filled_for_fun.py
  2. account/models.py
    • Remove field is_filled_for_fun

Tests

  1. account/tests/test_api.py
  2. profiles/tests/api/test_question.py
    • Remove is_filled_for_fun field tests

@juuso-j juuso-j added the enhancement New feature or request label Apr 11, 2024
@juuso-j juuso-j requested a review from ezkat April 11, 2024 07:09
@juuso-j juuso-j self-assigned this Apr 11, 2024
@juuso-j juuso-j merged commit f2d5e70 into develop Apr 11, 2024
3 checks passed
@juuso-j juuso-j mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkat ezkat ezkat approved these changes

Assignees

@juuso-j juuso-j

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juuso-j @ezkat