Feedback

[github-classroom]

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

• Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
• Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
• If you turned on autograding, then click the Checks tab to see the results.
• This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
  For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @nikhilk7153 @MinhPhan8803 @xxxfzxxx @akrakman @sd-20

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
app.py	173	10	94%	47–58
auth.py	9	0	100%
config.py	1	0	100%
decorators.py	27	0	100%
dataholders
apt.py	9	0	100%
mainpage_get.py	16	0	100%
review.py	7	0	100%
user.py	8	0	100%
pages
login.py	29	0	100%
mainpage.py	118	0	100%
userpage.py	53	0	100%
TOTAL	450	10	98%

Tests	Skipped	Failures	Errors	Time
54	0 💤	0 ❌	0 🔥	1.493s ⏱️

[gitguardian]

⚠️ GitGuardian has uncovered 32 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	3dc82e1	src/backend/app.py	View secret
-	Generic High Entropy Secret	3dc82e1	src/backend/tests/test_userpage.py	View secret
-	Generic Password	3dc82e1	src/backend/tests/test_userpage.py	View secret
-	Generic High Entropy Secret	a357b1c	src/backend/tests/test_userpage.py	View secret
-	Generic Password	a357b1c	src/backend/tests/test_userpage.py	View secret
-	Generic Password	a357b1c	src/backend/tests/test_userpage.py	View secret
-	Generic Password	dd12134	src/backend/tests/test_userpage.py	View secret
-	Generic High Entropy Secret	54a7f6a	src/backend/app.py	View secret
-	Generic High Entropy Secret	54a7f6a	src/backend/app.py	View secret
-	Generic High Entropy Secret	54a7f6a	src/backend/tests/test_app.py	View secret
-	Generic Password	54a7f6a	src/backend/tests/test_userpage.py	View secret
-	Generic Password	54a7f6a	src/backend/tests/test_userpage.py	View secret
-	Generic High Entropy Secret	73ee854	src/backend/app.py	View secret
-	Generic High Entropy Secret	73ee854	src/backend/app.py	View secret
-	Generic High Entropy Secret	73ee854	src/backend/tests/test_app.py	View secret
-	Generic Password	73ee854	src/backend/tests/test_userpage.py	View secret
-	Generic Password	73ee854	src/backend/tests/test_userpage.py	View secret
-	Generic High Entropy Secret	2b34de5	src/backend/app.py	View secret
-	Generic High Entropy Secret	2b34de5	src/backend/tests/test_app.py	View secret
-	Generic High Entropy Secret	6e4a2a6	src/backend/app.py	View secret
-	Generic High Entropy Secret	6e4a2a6	src/backend/tests/test_app.py	View secret
-	Generic Password	599cc09	src/backend/tests/test_userpage.py	View secret
-	Generic Password	65a31bd	src/backend/tests/test_userpage.py	View secret
-	Generic Password	a9466d2	src/backend/tests/test_userpage.py	View secret
-	Generic Password	1e12232	src/backend/tests/test_userpage.py	View secret
-	Generic Password	1e12232	src/backend/tests/test_userpage.py	View secret
-	Generic Password	21ee58d	src/backend/tests/test_userpage.py	View secret
-	Generic Password	21ee58d	src/backend/tests/test_userpage.py	View secret
-	Google OAuth2 Keys	c7131d7	src/backend/app.py	View secret
-	Google OAuth2 Keys	c7131d7	src/backend/app.py	View secret
-	Google OAuth2 Keys	f92e514	src/backend/app.py	View secret
-	Google OAuth2 Keys	f92e514	src/backend/app.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>