Skip to content

Commit

Permalink
Merge pull request #31 from CS222-UIUC/minh/fix_eslint
Browse files Browse the repository at this point in the history
Fix eslint
  • Loading branch information
MinhPhan8803 authored Oct 22, 2022
2 parents 93b95d7 + 8408bcc commit b46461e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ jobs:
# Make sure the actual branch is checked out when running on pull requests
ref: ${{ github.head_ref }}

- name: Install dependencies
run: npm install --no-package-lock eslint eslint-plugin-react --legacy-peer-deps
working-directory: src/frontend/

- name: Run ESLint
run: npx eslint src/. --ext .js,.jsx,.ts,.tsx
run: npx eslint --max-warnings 0 $(git ls-files '*.js' '*.jsx' '*.ts' '*.tsx')
working-directory: src/frontend/
4 changes: 2 additions & 2 deletions .github/workflows/jest-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ jobs:
- uses: actions/checkout@v3

- name: Install dependencies
run: npm ci
run: npm ci --legacy-peer-deps
working-directory: src/frontend

- name: Run tests
run: |
npx jest --coverage --coverageReporters json-summary
npx ts-jest config:init --coverage --coverageReporters json-summary
working-directory: src/frontend

- name: Jest coverage comment
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/sections/MainPageLeftSection.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import Searching from '../components/Searching';

export default function LeftSection(props: any) {
export default function LeftSection() {
return (
<div style={{ marginTop: '200px' }}>
<Searching />
Expand Down

6 comments on commit b46461e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL1590100%

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 0.482s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL1590100%

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 0.872s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL1590100%

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 0.794s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL1590100%

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 0.572s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL1590100%

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 0.594s ⏱️

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCover
TOTAL1590100%

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 0.791s ⏱️

Please sign in to comment.