fix: write-chain-info after u17 #10110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fc1f3ce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://abf6df81.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-defer-orchestration-agori.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Sep 18, 2024
gibson042
pushed a commit
that referenced
this pull request
Sep 19, 2024
_incidental_ ## Description We don't have a good design yet for the schema of Orchestration chain info in agoricNames, - #10109 It's not necessary for upgrade-17 so save it for another proposal. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations SDK still registers the info so the development experience doesn't differ. ### Testing Considerations Shouldn't break any existing tests. ### Upgrade Considerations Not yet deployed. Should be part of u17-rc1.
gibson042
added a commit
that referenced
this pull request
Sep 19, 2024
## Description Includes commits from the following PRs: * #10110 Does _not_ include a new upgrade name, because agoric-upgrade-17 has not yet been used in a proposal for any chain. Constructed using the following `git rebase -i HEAD` todo list: ``` # pull request #10110 branch ta/defer-orchestration-agoricNames label base-ta/defer-orchestration-agoricNames pick fc1f3ce fix: write-chain-info after u17 label ta/defer-orchestration-agoricNames reset base-ta/defer-orchestration-agoricNames merge -C 9cdb01d ta/defer-orchestration-agoricNames # fix: write-chain-info after u17 (#10110) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
We don't have a good design yet for the schema of Orchestration chain info in agoricNames,
It's not necessary for upgrade-17 so save it for another proposal.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
SDK still registers the info so the development experience doesn't differ.
Testing Considerations
Shouldn't break any existing tests.
Upgrade Considerations
Not yet deployed. Should be part of u17-rc1.