Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade-17 RC1 cherry picks #10113

Merged
merged 2 commits into from
Sep 19, 2024
Merged

chore: upgrade-17 RC1 cherry picks #10113

merged 2 commits into from
Sep 19, 2024

Conversation

gibson042
Copy link
Member

Description

Includes commits from the following PRs:

Does not include a new upgrade name, because agoric-upgrade-17 has not yet been used in a proposal for any chain.

Constructed using the following git rebase -i HEAD todo list:

# pull request #10110 branch ta/defer-orchestration-agoricNames
label base-ta/defer-orchestration-agoricNames
pick fc1f3ce1fe03bb2018edd4eb55d6561312d5fbe8 fix: write-chain-info after u17
label ta/defer-orchestration-agoricNames
reset base-ta/defer-orchestration-agoricNames
merge -C 9cdb01dde5fdc3418fc9d615ab640d9f859555e6 ta/defer-orchestration-agoricNames # fix: write-chain-info after u17 (#10110)

turadg and others added 2 commits September 18, 2024 21:38
@turadg @gibson042
fix: write-chain-info after u17
a25d3c6
@mergify @gibson042
fix: write-chain-info after u17 (#10110)
ed860d5 
_incidental_

## Description
We don't have a good design yet for the schema of Orchestration chain info in agoricNames,
- #10109

It's not necessary for upgrade-17 so save it for another proposal.

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations
SDK still registers the info so the development experience doesn't differ.

### Testing Considerations
Shouldn't break any existing tests.

### Upgrade Considerations
Not yet deployed. Should be part of u17-rc1.
@gibson042 gibson042 added the force:integration Force integration tests to run on PR label Sep 19, 2024
@gibson042 gibson042 merged commit a1453b2 into dev-upgrade-17 Sep 19, 2024
82 of 88 checks passed
@gibson042 gibson042 deleted the gibson-upgrade-17-rc1-cherry-picks branch September 19, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xpatrickdev 0xpatrickdev 0xpatrickdev approved these changes

@turadg turadg Awaiting requested review from turadg

@mhofman mhofman Awaiting requested review from mhofman

@LuqiPan LuqiPan Awaiting requested review from LuqiPan

Assignees
No one assigned
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @0xpatrickdev @turadg